Script for updating layers.#25
Conversation
randomorder
requested review from
lpasquali
and removed request for
randomorder
|
can you test / review this @lpasquali ? |
lpasquali
left a comment
lpasquali
left a comment
There was a problem hiding this comment.
this script has nothing to do with performances, it should be moved under utils.
lpasquali
left a comment
lpasquali
left a comment
There was a problem hiding this comment.
Please add requirements.txt for python modules used
| password = sys.argv[3] | ||
| layer_file = sys.argv[4] | ||
| xml_file = sys.argv[5] | ||
|
|
There was a problem hiding this comment.
please add checks to validate presence of correct arguments and, if something is not right, print the usage you put on top.
lpasquali
left a comment
lpasquali
left a comment
There was a problem hiding this comment.
please validate arguments and print an usage in case something is missing
|
Hello @akshayb2022, I reviewed you code, please check my comments and update it with changes requested, many thanks in advance! |
Hello @lpasquali |
|
hello @akshayb2022 I see you made most of changes requested. |
Done, please check |
|
are we done here @lpasquali ? |
3 participants
./update_tile_layers.py geoserver_url geoserver_username geoserver_pass ./layers.txt tl_config_template.xml