Fix displacement-offset conversion and update geostyler-style#1079
Merged
KaiVolland merged 1 commit intomainfrom Mar 2, 2026
Merged
Fix displacement-offset conversion and update geostyler-style#1079KaiVolland merged 1 commit intomainfrom
KaiVolland merged 1 commit intomainfrom
Conversation
also includes some linting
hwbllmnn
approved these changes
Mar 2, 2026
|
🎉 This PR is included in version 8.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the displacement-offset conversion logic to ensure correct values are used by introducing new conversion functions. Be aware that this also fixes a sign error that seems to be in the parser for a long time. As the y value of SLD-displacment and geostyler-style-offset have opposite meanings.
Additionally, update the
geostyler-styledependency version and perform some linting improvements.This fixes #1074