-
Notifications
You must be signed in to change notification settings - Fork 207
Add handling of GeoDoubleParams, GeoAsciiParams to GeoKeyDirectory #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jo-chemla
wants to merge
9
commits into
geotiffjs:master
Choose a base branch
from
jo-chemla:fix-geokeys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2a6a5cf
Parse DOUBLE GeoKeys as well as ASCII - not only GeogCitationGeoKey
jo-chemla 332043c
rework for simple pass to get all offsets and values for ascii/double
jo-chemla f9011a7
touch-ups, using toArray for simpler handling of arrays and simple do…
jo-chemla 547c304
Add tests for DOUBLE, ASCII GeoKeys to geotiffwriter
jo-chemla ef867a8
fix typo redefining toArray
jo-chemla 8cd3ad1
Move geotiffwriter spec test GeoAsciiParams/GeoDoubleParams into geot…
jo-chemla 667b056
Do a single for-loop pass to append to corresponding directory for SH…
jo-chemla ab0852f
Fix linting, tests passing
jo-chemla a14b2e8
change write test from closeTo to equal
jo-chemla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jo-chemla , could you provide a little more background on why this was necessary? I'm assuming it's a floating-point arithmetic thing, but would love to know a little more details. What part of the code do you think is causing this? Thank you!
on somewhat personal note: I've spent more time than I care to admit dealing with floating point arithmetic issues in the geo space, so I prefer it there's a way to preserves numbers while round-tripping that would be awesome!! It'll definitely save later downstream confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was actually not necessary, just switched these lines from
closeTo
toequal
. JS only uses double precision numbers, so it indeed looks like round-tripping does preserve these numbers!