Use native Float16Array instead of @petamoriken/float16 #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GHA needs to be updated to Node.js 24 to support Float16Array according to MDN to make the test pass |
|
@zakjan Can you try to update that in the CI? Also, does that mean we lose support for Node <24? I'm not sure if that is acceptable. Node 22 is still "active" |
|
@constantinius Updated, the build passes now. Yes, support for Node <24 would be lost when processing such arrays. I think it's fair to do this change as it helps to reduce the dependencies in favour of the native support. Any other array types still support Node <24. |
|
From https://github.com/nodejs/Release:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #475