fix transfering large TileOffsets to the worker #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we are using Geotiffjs to show large cloud optimized geotiffs in a webmap using openlayers.
We unfortunatly saw really bad performance with larger Datasets with millions of tiles. After some profiling and debugging we found out that geotiff.js transfers the TileOffsets Array to each decoding worker. This produced a visible lag viewing a Geotiff with 1.5mio tiles at the lowest level.
Our fix just does not transfer the TileOffsets to the decoding worker. We could not find any usage of the Array in the "worker". Does the fix make sense or are the TileOffsets used anywhere else in the workers, we did not see ?
Best,
Jannes