Skip to content

Conversation

@mbastian
Copy link
Member

No description provided.

@mbastian mbastian added this to the 0.8.1 milestone Oct 25, 2025
@mbastian mbastian linked an issue Oct 25, 2025 that may be closed by this pull request
@mbastian mbastian requested a review from Copilot October 26, 2025 08:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the legacy BitVector from the Colt library with Java's standard BitSet class and removes the Colt dependency from the project.

Key changes:

  • Migrated from cern.colt.bitvector.BitVector to java.util.BitSet across all graph implementation classes
  • Updated serialization/deserialization logic to maintain compatibility with legacy BitVector format
  • Replaced BitVector-specific operations (copy(), not(), size()) with BitSet equivalents (clone(), flip(), length())

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
pom.xml Removed the Colt library dependency
Serialization.java Updated serialization methods to handle BitSet while maintaining backward compatibility with BitVector format
GraphViewImpl.java Replaced BitVector with BitSet, updated bit operations, and simplified vector resizing logic
ColumnObserverImpl.java Migrated from BitVector to BitSet and removed manual growth logic
SerializationTest.java Updated test cases to use BitSet and added comprehensive serialization test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mbastian mbastian marked this pull request as ready for review October 26, 2025 15:47
@mbastian mbastian merged commit 579e46f into master Oct 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace legacy BitVector with BitSet

2 participants