Skip to content

Conversation

@llrs
Copy link
Contributor

@llrs llrs commented Jul 15, 2025

This PR makes it easier to post threads as requested on #172

For the moment I took the fastest approach and only works with text (what I need). The language and other parameters of the thread must be the same and the thread cannot begin as a reply to another toot (To avoid facilitating spam).
I took the liberty to (invisibly) return the ids of the messages posted.

I am not sure of the tests, I've written them but I have not recorded the cassette (I've read the guide but I found confusing if I first need to record the test and then replace it by the fake token token or what...).
Let me know if documentation and tests are enough

@schochastics
Copy link
Collaborator

looks good to me. I let @chainsawriot be the judge of the testing

@chainsawriot
Copy link
Collaborator

chainsawriot commented Jul 16, 2025

@llrs Thank you for the PR. At the moment, I can see two options

  1. Really provide a test with a unique cassette name and the cassette file(s)
  2. Remove the test for now; ATM consider the feature to be experimental; we(@schochastics and I)'ll come back to add tests when we have the bandwidth to do so.

@schochastics
Copy link
Collaborator

I am fine if the test is removed for now. Thanks @chainsawriot for the input

@llrs
Copy link
Contributor Author

llrs commented Jul 16, 2025

I removed the test. Thanks for the feedback!
Now to tweak the bot(s) to use this new feature 🚀

@schochastics
Copy link
Collaborator

Thanks for implementing this!

@schochastics schochastics merged commit 55cb396 into gesistsa:main Jul 16, 2025
7 checks passed
@llrs llrs deleted the threading branch July 16, 2025 17:32
@chainsawriot
Copy link
Collaborator

Does this person entry look good to you @llrs ? I would like to add you as an author.

person("Lluís", "Revilla Sancho", , "[email protected]", role = c("aut"),
        comment = c(ORCID = "0000-0001-9747-2570"))

@llrs
Copy link
Contributor Author

llrs commented Jul 16, 2025

@chainsawriot Yes, this is what I usually use. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants