chore: update toggle-devmode to use flatpak brewfiles #100
+36
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the toggle-devmode and install-system-flatpaks recipes. The changes transition from rpm-ostree to bootc for image switching and adopt Homebrew Brewfiles for managing Flatpak installations, which is a good improvement. However, I've found a couple of issues in the shell scripting: an unquoted variable that could cause issues with image names containing special characters, and a reused variable name that introduces a logical bug in the Flatpak installation logic. Addressing these will improve the robustness of the scripts.
inffy
requested review from
NiHaiden,
hanthor,
ledif and
renner0e
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #97