add: end-date in recurring payments #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rolznz , any update on this ? |
rolznz
reviewed
Oct 15, 2025
rolznz
reviewed
Oct 15, 2025
rolznz
reviewed
Oct 15, 2025
| </> | ||
| )} | ||
|
|
||
| <label className="zp-label"> |
Contributor
There was a problem hiding this comment.
I think the form is now cluttered with many options, and especially these new options, most users won't use. I think we should hide these (and maybe the cron option). We could use an "show advanced options" checkbox to show these. What do you think?
Contributor
Author
There was a problem hiding this comment.
I agree , How bout this?
Screen.Recording.2025-10-18.at.2.15.12.AM.mov
Contributor
Author
|
This is how it looks now: 
|
Contributor
Author
|
@rolznz , I alsp went ahead and modularised the code a bit , making the createSubscriptionForm file a lot leaner, which I felt was getting necessary. |
Contributor
|
@krrish-sehgal looks good, nice extraction of some of the code into new components too. I will give test it and give it a better review when I have some time. |
Contributor
Author
|
@rolznz, Sounds great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #69