Skip to content

fix: replace help dialog with modal#259

Merged
im-adithya merged 3 commits intomasterfrom
task-help-dialog
Feb 6, 2025
Merged

fix: replace help dialog with modal#259
im-adithya merged 3 commits intomasterfrom
task-help-dialog

Conversation

@im-adithya
Copy link
Copy Markdown
Member

DialogTrigger didn't work properly because it uses onPress which works differently in android (if you tap it and move away from the button/touchable opacity it won't trigger the function, as opposed to the onPressIn that we are replacing it with now which triggers as soon as the icon is tapped on)

I also tried to increase the padding to make the button bigger so we don't have to replace the Dialog but the Navigation bar already leaves space on the right. And we already are using onPressIn for the X icon when there are wallets available which works fine so I proceeded with this.

Screenshot

@im-adithya im-adithya requested a review from reneaaron February 4, 2025 19:55
Copy link
Copy Markdown
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check whether updating the rn-primitives / nativewind components / libs could possibly fix this problem?

By not using these components we lose e.g. darkmode ability and would need to define colors / paddings / etc. all on our own 🤔

@im-adithya
Copy link
Copy Markdown
Member Author

DialogTrigger component is directly imported from rn-primitives so we can't change that code to onPressIn instead of onPress, and the Modal component makes the whole thing easy align with nativewind so I think this is good (updated dark mode screenshot in the PR main comment)

@im-adithya im-adithya merged commit 63552d2 into master Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants