Merged
Conversation
reneaaron
reviewed
Feb 4, 2025
Contributor
reneaaron
left a comment
There was a problem hiding this comment.
Did you check whether updating the rn-primitives / nativewind components / libs could possibly fix this problem?
By not using these components we lose e.g. darkmode ability and would need to define colors / paddings / etc. all on our own 🤔
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DialogTriggerdidn't work properly because it usesonPresswhich works differently in android (if you tap it and move away from the button/touchable opacity it won't trigger the function, as opposed to theonPressInthat we are replacing it with now which triggers as soon as the icon is tapped on)I also tried to increase the padding to make the button bigger so we don't have to replace the Dialog but the Navigation bar already leaves space on the right. And we already are using
onPressInfor the X icon when there are wallets available which works fine so I proceeded with this.Screenshot