Fix: Wrap error title#264
Merged
im-adithya merged 2 commits intogetAlby:masterfrom Feb 7, 2025
kylemccullen:task-alert-title
Merged
Fix: Wrap error title#264im-adithya merged 2 commits intogetAlby:masterfrom kylemccullen:task-alert-title
im-adithya merged 2 commits intogetAlby:masterfrom
kylemccullen:task-alert-title
Conversation
Member
|
Thanks @kylemccullen, much appreciated! Yes, it would be good to remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #251
Add a boolean wrapText prop to CardTitle component that when set allows the text to wrap.
This pull request makes the assumption that wrapping text should not be the default, and is only desired on Alerts. If the intention is all CardTitle components should have text wrapped then numberOfLines can be removed.
In this screenshot the Alert title has wrapText prop set, while the title below does not.
This is my first pull request for this project. Any feedback is helpful!