feat: upgrade to react 19 and add document metadata support#1993
Open
zmjohnso wants to merge 1 commit intogetAlby:masterfrom
Open
feat: upgrade to react 19 and add document metadata support#1993zmjohnso wants to merge 1 commit intogetAlby:masterfrom
zmjohnso wants to merge 1 commit intogetAlby:masterfrom
Conversation
Contributor
|
@zmjohnso thanks for the PR, and thanks for keeping it simple. The other React 19 features and refactoring are not a priority for us right now, but thanks for the offering to work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates to React 19. See #1851
It also tests utilizes React 19's support for document metadata tags to add titles to top level routes, as suggested in #1851. This addresses #1837.
Tab title:
History:
These titles are mostly examples. Might want to update to something that makes more sense; I also might have missed pages. But if it is okay to go ahead with the React 19 upgrade, this should be easy to update in the future.
Additionally, if this looks good, I will work on additional follow-up PRs to take advantage of other React 19 features, such as form actions and
useTransition, as mentioned in #1851. But this would be a substantially larger refactor.