Download content exclusions from GitHub#1073
Open
dividedmind wants to merge 2 commits intodevelopfrom
Open
Conversation
It's currently unused and brings a lot of stuff in.
27d2d98 to
b4e12dd
Compare
b4e12dd to
953b119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to download and manage content exclusions from GitHub. The key changes include adding new utility functions for handling exclusions, modifying the chat completion service to ensure exclusions are downloaded, and adding tests for the new functionality.
vscode-gh-exclusion.mp4
New functionality for handling exclusions:
src/lib/exclusionUtils.ts: Added functions to download content exclusions (downloadContentExclusions), ensure exclusions are downloaded (ensureExclusionsDownloaded), and attempt to download exclusions (tryDownloadingExclusions). Also added functions to get GitHub tokens and handle errors during exclusion downloads.src/lib/fetchGHExclusions.ts: Added a new module to fetch content exclusions from GitHub, including thefetchGHExclusionsfunction and related types (GitHubContentExclusion,Rule,Scope).Modifications to chat completion service:
src/services/chatCompletion.ts: Updated theChatCompletionclass to try downloading exclusions during initialization and ensure exclusions are downloaded before handling requests. [1] [2] [3]Tests for new functionality:
test/unit/lib/fetchGHExclusions.test.ts: Added unit tests for thefetchGHExclusionsfunction to verify successful fetching, handling of 404 responses, and error handling for other response statuses.Dependency updates:
package.json: Removed the@appland/appmapdependency and cleaned up theresolutionssection. [1] [2]