Draft
Conversation
Introduces 'build/bundleConfig.ps1' to allow pre-configuring the extension VSIX package with custom settings and bundled binaries. This includes new documentation in 'build/bundleConfig.md' and a reference in 'DEVELOPMENT.md'.
Adds a new boolean configuration setting 'appMap.autoUpdateTools' (default: true) to allow users to disable automatic downloads and updates of AppMap CLI, Scanner, and Java agent tools. This provides more control over tool management.
Modifies 'build/updateResources.js' to store and reference the AppMap Java agent JAR with its version embedded in the filename (e.g., 'appmap-1.28.0.jar'). This improves clarity and consistency in asset management. Updates 'resources/versions.json' accordingly.
Re-architects the extension's asset management system
for AppMap CLI, Scanner, and Java agent tools. Key changes include:
- Introduction of a platform-appropriate cache directory
for downloaded binaries.
- Implementation of symlinks in '~/.appmap/bin' and
'~/.appmap/lib/java' pointing to cached or bundled assets.
- New 'AssetService.ensureAssets()' for robust tool presence
and update management, respecting the 'appMap.autoUpdateTools' setting.
- Unified asset listing ('listAssets') and version
extraction ('versionFromPath') logic.
- Support for pre-bundled binaries within the VSIX
'resources' directory.
- Removal of the '.download-complete' marker in favor of more robust checks.
Includes updated documentation ('doc/assets.md'), comprehensive test updates,
and adjustments to various commands and services to use the refactored asset handling.
…and common properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.