Conversation
devAsadNur
added
Need Dev Review
WalkthroughThe change updates the WooCommerce product data panel for the countdown timer module by modifying the discount input field. The input type is changed from text to number, and minimum and maximum constraints are set to 0 and 100, ensuring only valid percentage values can be entered. Changes
Sequence Diagram(s)sequenceDiagram
participant Admin as Product Admin
participant WCPanel as WooCommerce Product Data Panel
Admin->>WCPanel: Open product discount settings
WCPanel->>Admin: Render discount input (type=number, min=0, max=100)
Admin->>WCPanel: Enter discount value (validated client-side)
WCPanel->>Admin: Prevent invalid input (non-numeric, <0, >100)
Assessment against linked issues
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Includes/Modules/CountdownTimer/templates/wc-product-data-panels.php (1)
19-33: Excellent improvement to input validation!The changes effectively implement proper input validation for the discount percentage field by:
- Changing the input type to 'number'
- Setting minimum and maximum constraints (0-100)
- Modernizing the array syntax from
array()to[]These changes directly address the issue mentioned in #68 and will prevent users from entering invalid discount percentages.
Consider also adding a step attribute to control the decimal precision, if decimal percentages are allowed:
'custom_attributes' => [ 'min' => '0', 'max' => '100', + 'step' => '0.01', ],
devAsadNur
changed the title
mrabbani
deleted the
fix/validation-to-the-product-countdown-timer-discount-percentage-field
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit