Create post with tags from the UI#1240
Conversation
|
I achieved a first working version. I will look into making this optional through the configuration. |
| navigator.replaceState( | ||
| querystring.stringify({ | ||
| view: querystring.get("view"), | ||
| query: querystring.get("query"), | ||
| tags: newTags, | ||
| limit: querystring.getNumber("limit"), | ||
| }) |
There was a problem hiding this comment.
Pretty sure you don't need this?
There was a problem hiding this comment.
I'm trying to update the url while not reloading the page is it not the right way ?
There was a problem hiding this comment.
Ah I see what you were trying to do. I'd avoid using the querystring for this - it doesn't make sense for the add post page to manipulate the querystring like this. Can you change this to use the same cache that the title and description is being stored in - you can save a CSV string of the tag ids that are selected, that should work well I think.
mattwoberts
left a comment
mattwoberts
left a comment
There was a problem hiding this comment.
Looks like it's coming on..
|
Hi @MercierMateo , how's it all going? Are you waiting on me for anything? |
|
I got busy and forgot about it sorry, thanks for reminding me i'll look back into it. Is the way I did it OK UI wise ? I don't know if it fits in the design. I will do the enable/disable part in the next days |
The design is looking good, it just needs some spacing where the arrow is, go for the same size spacing that you have between the title and description... 
|
|
@MercierMateo Hi, are you able to complete your work on this? Looks like you're pretty close with what you have? |
|
Sorry I had no time recently but I think I added what we talked about, tell me if I forgot anything. |
|
Tests are failing - there is a little more JSON that isn't in the expected HTML now:
|
|
Superseded - this work was completed in #1306 |
2 participants
Issue: #1211
Follow up on this closed PR : #1221
Visitors can now create post with tags from the ui