Replace loose equality with strict equality in SignInControl#1392
Merged
mattwoberts merged 2 commits intologin_codesfrom Nov 15, 2025
Merged
Replace loose equality with strict equality in SignInControl#1392mattwoberts merged 2 commits intologin_codesfrom
mattwoberts merged 2 commits intologin_codesfrom
Conversation
Co-authored-by: mattwoberts <109196+mattwoberts@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on login codes draft
Replace loose equality with strict equality in SignInControl
Nov 15, 2025
mattwoberts
approved these changes
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback from #1389 to use strict equality operators for type-safe comparisons.
Changes
==with===inSignInControl.tsx:renderSigninEmailButton()(3 instances)disabledprop (1 instance)All changes involve comparisons against the
EmailSigninStepenum:✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.