Fix: Use strong key for sign-in email link#1468
Merged
mattwoberts merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
…manual entry The sign-in email link previously used the same 6-digit numeric code as the manual entry flow, making it brute-forceable. Now generates a separate 64-char cryptographic link_key for the email URL while keeping the 6-digit code for manual entry (which requires the email address, limiting attack surface). Also makes the 6-digit code single-use — reuse returns 400 instead of allowing re-authentication. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1458
Summary
link_keyfor the email URL, while keeping the 6-digit code for manual entry (which requires the email address, limiting the attack surface)Test plan
make lintpassesTestVerifySignInCodeHandler_AlreadyVerifiedCode_ShouldRejectmake migrateto apply the newcodecolumn migration🤖 Generated with Claude Code