Filename does not need forward slash at the end...#45
Open
isagarjadhav wants to merge 1 commit intogetgrav:developfrom
Open
Filename does not need forward slash at the end...#45isagarjadhav wants to merge 1 commit intogetgrav:developfrom
isagarjadhav wants to merge 1 commit intogetgrav:developfrom
Conversation
…nd parameter from instance. Export to CSV is not working. While creating instance $csv_file, the forward slash is added and a second unnecessary parameter is passed. $tmp defined on line 249, itself is the completely qualified path to file. It can be used as it is. Bug reported on Stackoverflow - https://stackoverflow.com/questions/71019105/i-trying-to-download-as-csv-from-grav-site-using-data-manager-but-getting-erro/71436625#71436625
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused second parameter from instance.
Export to CSV is not working. While creating instance $csv_file, the forward slash is added and a second unnecessary parameter is passed.
$tmp defined on line 249, itself is the completely qualified path to file. It can be used as it is.
Bug reported on Stackoverflow -
https://stackoverflow.com/questions/71019105/i-trying-to-download-as-csv-from-grav-site-using-data-manager-but-getting-erro/71436625#71436625