Skip to content

Conversation

@irauschek
Copy link

Added missing markdown evaluation of checkbox labels within data.html.twig if activated. To be able to send the agreed terms of condition as link within an email - see #227 and #253
Translate the label into the current language set in the admin interface user preferences if defined.
Furthermore added the possibility to use markdown syntax within labels of checkboxes, date, display, email, file, month, password, radio, range, select_optgroup, select, tel, text, textarea, and time too - see #281

@rhukster
Copy link
Member

I feel like we need to simplify things a bit in forms.. slight changes should not have this big an impact. I'm going to be reviewing forms twig a bit next week.

@mahagr
Copy link
Member

mahagr commented Jul 15, 2019

I've started to use {% use ... %} to override common blocks in a single file, which seems to be a good match for this case.

@irauschek irauschek force-pushed the feature/markdown-support-for-labels branch from 862f4bf to 1b04919 Compare August 30, 2019 01:05
@irauschek irauschek force-pushed the feature/markdown-support-for-labels branch from 1b04919 to ece664d Compare November 5, 2019 22:10
@irauschek irauschek force-pushed the feature/markdown-support-for-labels branch 2 times, most recently from 7a5bff6 to ece664d Compare December 17, 2019 00:08
@irauschek
Copy link
Author

Despite the missing markdown evaluation of checkbox labels within data.html.twig if activated, to be able to send the agreed terms of condition as link within an email - see #227 and #253, all other addressed issues have been solved in release 4.0.0

@irauschek irauschek closed this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants