Open
Conversation
mahagr
suggested changes
Feb 28, 2022
Member
mahagr
left a comment
mahagr
left a comment
There was a problem hiding this comment.
I would make them internal instead of deprecated for now. Some of those are still being used before Grav initialization.
Contributor
Author
|
I do not understand. Your own comment claims: Line 73 in 3dd0cab Deprecation just means that the variables should not be used for new code and old code should be refactored in the future. |
Needed for IDE and linter support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for IDE and linter support.