Skip to content

Fix JSON-LD schema params mapping#1332

Merged
markdumay merged 1 commit intogethinode:mainfrom
timcappalli:main
Dec 30, 2024
Merged

Fix JSON-LD schema params mapping#1332
markdumay merged 1 commit intogethinode:mainfrom
timcappalli:main

Conversation

@timcappalli
Copy link
Contributor

I noticed that the JSON-LD metadata was still showing the default image for image/logo after setting the value under [schema] in params.toml.

The if statement for the logo/image uses schemaType. All other references are .Site.Params.schema.type.

After changing to ...schema.type to match the others, the logo/image is correctly being updated with the value from params.

@netlify
Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for gethinode-demo ready!

Name Link
🔨 Latest commit e64fdee
🔍 Latest deploy log https://app.netlify.com/sites/gethinode-demo/deploys/676f492778251f0008afc909
😎 Deploy Preview https://deploy-preview-1332--gethinode-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@markdumay
Copy link
Collaborator

Thanks, @timcappalli, for spotting this and for the PR!

@markdumay markdumay merged commit 05ea55d into gethinode:main Dec 30, 2024
11 checks passed
@markdumay markdumay added the bug Something isn't working label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants