Fix JSON-LD schema params mapping#1332
Merged
markdumay merged 1 commit intogethinode:mainfrom Dec 30, 2024
timcappalli:main
Merged
Fix JSON-LD schema params mapping#1332markdumay merged 1 commit intogethinode:mainfrom timcappalli:main
markdumay merged 1 commit intogethinode:mainfrom
timcappalli:main
Conversation
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
Thanks, @timcappalli, for spotting this and for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I noticed that the JSON-LD metadata was still showing the default image for image/logo after setting the value under
[schema]inparams.toml.The if statement for the logo/image uses
schemaType. All other references are.Site.Params.schema.type.After changing to
...schema.typeto match the others, the logo/image is correctly being updated with the value from params.