Skip to content

[Chore] Update packages and resolve github.com/oasdiff/yaml induced error#1130

Closed
TDiblik wants to merge 2 commits intogetkin:masterfrom
TDiblik:master
Closed

[Chore] Update packages and resolve github.com/oasdiff/yaml induced error#1130
TDiblik wants to merge 2 commits intogetkin:masterfrom
TDiblik:master

Conversation

@TDiblik
Copy link

@TDiblik TDiblik commented Feb 19, 2026

Hey, while upgrading my package gofiber-swagger, I've encountered the following error:

[gofiber-swagger] (master) > make update
go get -u all
go mod tidy
gofmt -w -l .
/Applications/Xcode.app/Contents/Developer/usr/bin/make test
go test ./gofiberswagger
# github.com/getkin/kin-openapi/openapi3
../../../go/pkg/mod/github.com/getkin/kin-openapi@v0.133.0/openapi3/marsh.go:28:49: not enough arguments in call to yaml.UnmarshalWithOrigin
	have ([]byte, any, bool)
	want ([]byte, interface{}, bool, string, ..."github.com/oasdiff/yaml".JSONOpt)
FAIL	github.com/TDiblik/gofiber-swagger/gofiberswagger [build failed]
FAIL
make[1]: *** [test] Error 1
make: *** [update] Error 2

There's open discussion in the upstream repo about this.

This PR fixes the issue and updates other packages as well.

Command used for the upgrade: go get -u all && go mod tidy && gofmt -w -l .
I've made sure that all tests pass:

[kin-openapi] (master) > go test ./...                                                    
?   	github.com/getkin/kin-openapi/cmd/validate	[no test files]
ok  	github.com/getkin/kin-openapi/openapi2	(cached)
ok  	github.com/getkin/kin-openapi/openapi2conv	(cached)
ok  	github.com/getkin/kin-openapi/openapi3	(cached)
ok  	github.com/getkin/kin-openapi/openapi3filter	(cached)
ok  	github.com/getkin/kin-openapi/openapi3gen	(cached)
?   	github.com/getkin/kin-openapi/openapi3gen/internal/subpkg	[no test files]
ok  	github.com/getkin/kin-openapi/routers	(cached)
ok  	github.com/getkin/kin-openapi/routers/gorillamux	(cached)
ok  	github.com/getkin/kin-openapi/routers/legacy	(cached)
ok  	github.com/getkin/kin-openapi/routers/legacy/pathpattern	(cached)

TDiblik referenced this pull request in oasdiff/yaml Feb 19, 2026
Pass source file path to yaml3 decoder so origin locations include
the file they were parsed from.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@TDiblik
Copy link
Author

TDiblik commented Feb 19, 2026

closed in favor of oasdiff/yaml@4f1c3d0#r177631556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant