Skip to content

Conversation

@thomasjib
Copy link
Contributor

This enables metric tracking for all protocols

Copilot AI review requested due to automatic review settings January 22, 2026 19:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enables metric tracking for all protocols by implementing a new MetricsTracker that integrates with OpenTelemetry to track connection metrics such as bytes transferred, connection counts, and connection duration.

Changes:

  • Added new MetricsTracker implementation in the metrics package to wrap connections with metric tracking
  • Updated OpenTelemetry dependencies from v1.38.0 to v1.39.0 across multiple packages
  • Integrated metrics tracker into the application startup flow with conditional enablement based on meter provider configuration

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
metrics/tracker.go New connection tracker that wraps connections and packet connections to enable metrics collection
go.mod Updated OpenTelemetry dependencies to v1.39.0 and added new direct dependencies
go.sum Checksums for updated and new dependencies
cmd/main.go Added noop meter provider initialization and import statements
cmd/cmd_run.go Integrated metrics tracker with conditional enablement based on meter provider type
.gitignore Added .DS_Store exclusion for macOS system files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@myleshorton
Copy link
Contributor

This is great!

Copy link
Collaborator

@garmr-ulfr garmr-ulfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment. LGTM otherwise.

@thomasjib thomasjib closed this Jan 23, 2026
@thomasjib thomasjib deleted the thomas/metrics branch January 23, 2026 14:51
@thomasjib thomasjib mentioned this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants