-
Notifications
You must be signed in to change notification settings - Fork 0
Thomas/metrics #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thomas/metrics #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request enables metric tracking for all protocols by implementing a new MetricsTracker that integrates with OpenTelemetry to track connection metrics such as bytes transferred, connection counts, and connection duration.
Changes:
- Added new
MetricsTrackerimplementation in the metrics package to wrap connections with metric tracking - Updated OpenTelemetry dependencies from v1.38.0 to v1.39.0 across multiple packages
- Integrated metrics tracker into the application startup flow with conditional enablement based on meter provider configuration
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| metrics/tracker.go | New connection tracker that wraps connections and packet connections to enable metrics collection |
| go.mod | Updated OpenTelemetry dependencies to v1.39.0 and added new direct dependencies |
| go.sum | Checksums for updated and new dependencies |
| cmd/main.go | Added noop meter provider initialization and import statements |
| cmd/cmd_run.go | Integrated metrics tracker with conditional enablement based on meter provider type |
| .gitignore | Added .DS_Store exclusion for macOS system files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This is great! |
garmr-ulfr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one comment. LGTM otherwise.
This enables metric tracking for all protocols