adding WATER detour option for downloading and seeding#187
Conversation
lantern-water magnet downloader and seeder now support a http client transport
…g the WASM file and seeding
There was a problem hiding this comment.
Pull request overview
This PR updates the WATER outbound’s WASM download + seeding pipeline to use the latest lantern-water APIs and to route HTTP traffic through the Radiance Kindling HTTP client stack.
Changes:
- Update
lantern-waterdependency to a newer revision that supports injecting an*http.Clientfor WASM downloading and seeding. - Introduce a shared
http.Clientin the WATER outbound, optionally sourcing its transport fromradiance/kindling. - Update Go module dependencies (
go.mod/go.sum) to includegithub.com/getlantern/radianceand related transitive upgrades.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| protocol/water/outbound.go | Creates a shared HTTP client (optionally Kindling-backed) and passes it into the WASM downloader and seeder. |
| go.mod | Bumps lantern-water and adds getlantern/radiance plus refreshed indirect dependencies. |
| go.sum | Reflects the updated dependency graph for the new module versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Since radiance depends on lantern-box, lantern-box shouldn't also depend on radiance. Introducing that circular dependency makes it very fragile—changes to radiance now have the potential to break a dependency, or lantern-box would have to use an older version. This makes it very difficult to maintain. |
The detour option will be used for using another outbound to download and seed the WASM file
garmr-ulfr
left a comment
There was a problem hiding this comment.
LGTM! Just the one comment.
This PR: