Skip to content

downgrade to go1.24#188

Merged
WendelHime merged 4 commits intomainfrom
fix/downgrade-to-go1.24
Mar 19, 2026
Merged

downgrade to go1.24#188
WendelHime merged 4 commits intomainfrom
fix/downgrade-to-go1.24

Conversation

@WendelHime
Copy link
Copy Markdown
Contributor

@WendelHime WendelHime commented Mar 18, 2026

This pull request remove some binaries and downgrade lantern-box to 1.24

Copilot AI review requested due to automatic review settings March 18, 2026 18:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s Go/tooling setup to run the metrics tracker test under the synctest GOEXPERIMENT, while also aligning the repository’s Go version and module dependencies (notably OpenTelemetry and x/net) to the chosen toolchain.

Changes:

  • Gate tracker/metrics/tracker_test.go behind //go:build goexperiment.synctest and switch to synctest.Run(...).
  • Run the test suite with GOEXPERIMENT=synctest via make test.
  • Align build/toolchain inputs by updating go.mod/go.sum dependency versions and the Docker builder image Go version.

Reviewed changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tracker/metrics/tracker_test.go Adds goexperiment.synctest build gating and updates synctest invocation for the tracker metrics test.
Makefile Ensures tests run with GOEXPERIMENT=synctest.
go.mod Changes Go version directive and downgrades OpenTelemetry + x/net requirements.
go.sum Syncs checksums with the updated dependency versions.
Dockerfile Updates the builder image from Go 1.25 to Go 1.24.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@WendelHime WendelHime merged commit 7f6052f into main Mar 19, 2026
2 checks passed
@WendelHime WendelHime deleted the fix/downgrade-to-go1.24 branch March 19, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants