Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Go/tooling setup to run the metrics tracker test under the synctest GOEXPERIMENT, while also aligning the repository’s Go version and module dependencies (notably OpenTelemetry and x/net) to the chosen toolchain.
Changes:
- Gate
tracker/metrics/tracker_test.gobehind//go:build goexperiment.synctestand switch tosynctest.Run(...). - Run the test suite with
GOEXPERIMENT=synctestviamake test. - Align build/toolchain inputs by updating
go.mod/go.sumdependency versions and the Docker builder image Go version.
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tracker/metrics/tracker_test.go | Adds goexperiment.synctest build gating and updates synctest invocation for the tracker metrics test. |
| Makefile | Ensures tests run with GOEXPERIMENT=synctest. |
| go.mod | Changes Go version directive and downgrades OpenTelemetry + x/net requirements. |
| go.sum | Syncs checksums with the updated dependency versions. |
| Dockerfile | Updates the builder image from Go 1.25 to Go 1.24. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
garmr-ulfr
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request remove some binaries and downgrade lantern-box to 1.24