Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds instrumentation to selector and URLTest outbound protocols by wrapping them with OpenTelemetry tracing capabilities.
- Adds selector and urltest to the list of supported protocols
- Registers new instrumented versions of Selector and URLTest outbounds
- Implements tracing for network operations (DialContext, ListenPacket) and connection handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| protocol/register.go | Adds "selector" and "urltest" to supported protocols and registers their instrumented versions |
| protocol/group/urltest.go | Implements instrumented URLTest outbound with OpenTelemetry tracing for network operations |
| protocol/group/selector.go | Implements instrumented Selector outbound with OpenTelemetry tracing for network and connection operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
garmr-ulfr
approved these changes
Aug 29, 2025
Collaborator
garmr-ulfr
left a comment
garmr-ulfr
left a comment
There was a problem hiding this comment.
One comment, but otherwise LGTM!
…hen expected" This reverts commit 93c63d5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.