Bugfix/8762 Multiple changes to align S3 multipart checksum support with AWS functionality#8875
Draft
sophieil wants to merge 10 commits intogetmoto:masterfrom
Draft
Conversation
…hecksum type - full_object variants currently fail
…te-checksums-suffix-issue' into bugfix/8762-composite-checksums-suffix-issue
Author
|
Thanks for triggering the checks @bblommers, I will look through and fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8762
Also addresses the point about full object checksums mentioned in #8760, enabling full object checksums where applicable and adding support for CRC64NVME checksums.
Multipart checksum behaviour has been based on AWS docs here, verified using the attached script
moto-8762-aws-behaviour-demo.py.txt which produces the following output: