feat: add OpenTableFormatInput support for Glue CreateTable#9886
Open
raajheshkannaa wants to merge 5 commits intogetmoto:masterfrom
Open
feat: add OpenTableFormatInput support for Glue CreateTable#9886raajheshkannaa wants to merge 5 commits intogetmoto:masterfrom
raajheshkannaa wants to merge 5 commits intogetmoto:masterfrom
Conversation
When OpenTableFormatInput with IcebergInput is provided to CreateTable, store the parameter and set table_type=ICEBERG in table Parameters, matching AWS behavior. Fixes getmoto#9705
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9886 +/- ##
==========================================
- Coverage 93.12% 93.12% -0.01%
==========================================
Files 1314 1314
Lines 119306 119310 +4
==========================================
+ Hits 111101 111104 +3
- Misses 8205 8206 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9705
Summary
OpenTableFormatInputparameter increate_tablefor Glue Iceberg tablesIcebergInputis provided, automatically setParameters.table_typetoICEBERGandParameters.metadata_locationfrom the inputget_tableresponses via the table'sParametersdictChanges
moto/glue/models.py: accept and processOpenTableFormatInputinFakeTable.__init__andGlueBackend.create_tablemoto/glue/responses.py: passOpenTableFormatInputfrom request body to backendtests/test_glue/test_datacatalog.py: tests for Iceberg table creation and parameter verification