fix: ACM root CA and certificate chain formatting#9898
Open
dsp0x4 wants to merge 1 commit intogetmoto:masterfrom
Open
fix: ACM root CA and certificate chain formatting#9898dsp0x4 wants to merge 1 commit intogetmoto:masterfrom
dsp0x4 wants to merge 1 commit intogetmoto:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9898 +/- ##
=======================================
Coverage 93.12% 93.12%
=======================================
Files 1314 1314
Lines 119430 119430
=======================================
Hits 111224 111224
Misses 8206 8206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
AWS_ROOT_CAstring has a leading whitespace on its last line, which breaks standard PEM formatting. In addition, the mockedExportCertificateandGetCertificateAPI responses were lacking the trailing newline character from theCertificateChainvalue, unlike the real AWS API's.Tests and linting have been validated.
Please let me know if there is any issue with my contribution. Thanks!