-
Notifications
You must be signed in to change notification settings - Fork 85
Updating more challenging packages for 2025.4 #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52c4680 to
ae907a0
Compare
2 tasks
a65e440 to
b2e6192
Compare
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
requested changes
Dec 4, 2025
Contributor
alxndrsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bunch of new Sentry integration whose appearance is described by the comment above the test which is changed:
// * Sentry may change the default integrations. In the case of new default
// integrations, consider if they should be added to the expected list
// below. In the case of default integrations being removed, consider if
// they should be re-enabled manually.
Might be worth separating Sentry upgrade to a different PR, where these can be considered in more detail.
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
alxndrsn
reviewed
Dec 4, 2025
Member
Author
|
Moved sentry upgrade out to a separate PR: #1706 |
b2e6192 to
c9d357d
Compare
alxndrsn
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to:
Working on
Trying to upgrade more challenging npm packages.
See the individual commits for how certain libraries required a slightly different way of importing and small changes to the code (uuid, fetch-cookie, csv-parse, csv-stringify)
After these updates,
npm outdatedlooks smaller and is mostly the known troublemakers:What has been done to verify that this works as intended?
Tests
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes