Skip to content

Conversation

@ktuite
Copy link
Member

@ktuite ktuite commented Dec 3, 2025

Followup to:

Working on

Trying to upgrade more challenging npm packages.

  • @sentry/node
  • csv-parse
  • csv-stringify
  • luxon
  • uuid
  • @playwright/test
  • @redocly/cli
  • @sinonjs/fake-timers
  • fetch-cookie

See the individual commits for how certain libraries required a slightly different way of importing and small changes to the code (uuid, fetch-cookie, csv-parse, csv-stringify)

After these updates, npm outdated looks smaller and is mostly the known troublemakers:

What has been done to verify that this works as intended?

Tests

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite changed the title Upgrading fetch-cookie and how it is imported Updating more challenging packages for 2025.4 Dec 3, 2025
@ktuite ktuite force-pushed the ktuite/more_2025_4_deps_2 branch from 52c4680 to ae907a0 Compare December 4, 2025 00:11
@ktuite ktuite marked this pull request as ready for review December 4, 2025 00:25
Base automatically changed from ktuite/upgrade_2025_4_deps to master December 4, 2025 05:38
@ktuite ktuite force-pushed the ktuite/more_2025_4_deps_2 branch from a65e440 to b2e6192 Compare December 4, 2025 05:41
Copy link
Contributor

@alxndrsn alxndrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of new Sentry integration whose appearance is described by the comment above the test which is changed:

    // * Sentry may change the default integrations.  In the case of new default                                        
    //   integrations, consider if they should be added to the expected list                                            
    //   below.  In the case of default integrations being removed, consider if                                         
    //   they should be re-enabled manually. 

Might be worth separating Sentry upgrade to a different PR, where these can be considered in more detail.

@ktuite ktuite mentioned this pull request Dec 5, 2025
2 tasks
@ktuite
Copy link
Member Author

ktuite commented Dec 5, 2025

Moved sentry upgrade out to a separate PR: #1706

@ktuite ktuite force-pushed the ktuite/more_2025_4_deps_2 branch from b2e6192 to c9d357d Compare December 5, 2025 05:15
@ktuite ktuite requested a review from alxndrsn December 5, 2025 05:34
@ktuite ktuite merged commit d210ccc into master Dec 5, 2025
12 checks passed
@ktuite ktuite deleted the ktuite/more_2025_4_deps_2 branch December 5, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update backend dependencies prior to regression testing (v2025.4)

4 participants