Closed
Conversation
* generate public/client-config.js at foreman startup * remove nginx's special handling for client-config.js Closes getodk#1034
Member
|
I'm interested in what you think of #1038, but this approach also looks reasonable to me. It'd be nice to remove the addition of Docker in the Procfile though, since that's being discussed at #1035.
We have special logic around this file in prod as well, so my feeling is that it's OK to have some special handling in this local nginx config. But I also don't have any attachment to it: I'd be OK generating client-config.json locally, as this PR does, if you think that's the best approach. |
Contributor
Author
|
#1034 not recreatable, so this change is not required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1034