Conversation
|
@ktuite, who do you think should review this PR? I have context on the existing update modal, and I'd be happy to review. But I'm also happy for Sadiq to review if you two have already chatted about it. |
| { | ||
| "en": { | ||
| "upload": "Upload Entities", | ||
| "new": "New", |
There was a problem hiding this comment.
How about adding a comment for translators? They may need to know the noun that "New" applies to in order to inflect "New".
| <!-- | ||
| Copyright 2026 ODK Central Developers | ||
| See the NOTICE file at the top-level directory of this distribution and at | ||
| https://github.com/getodk/central-frontend/blob/master/NOTICE. | ||
|
|
||
| This file is part of ODK Central. It is subject to the license terms in | ||
| the LICENSE file found in the top-level directory of this distribution and at | ||
| https://www.apache.org/licenses/LICENSE-2.0. No part of ODK Central, | ||
| including this file, may be copied, modified, propagated, or distributed | ||
| except according to the terms contained in the LICENSE file. | ||
| --> |
There was a problem hiding this comment.
We don't need file headers anymore. 🎉 getodk/governance#2 (comment) So I think this can be removed.
|
I think we discussed on Thursday that @ktuite is still working on this issue. So I think we can go ahead and mark this PR as draft. |
|
On my way to #1480 I had this as an intermediary. Mix of old form-group input field with unstyled textareas form-group input field that shows label below input |
2 participants
Was related to getodk/central#1638
Sadiq, Nicole, and I talked about reusing the update entity modal. When I looked into it, there were enough differences (different API route, conditional things about showing/not showing the middle column, conditional things about comparing new data with old data or not) that it seemed simpler to make a new component. It's inspired by the update component, though, and it uses the same EntityUpdateRow component, which has been changed to optionally not show the "old value" middle column.
New create modal:
Create modal with values filled in:
Update modal for reference:
What has been done to verify that this works as intended?
Trying it, new tests.
Why is this the best possible solution? Were any other approaches considered?
Maybe refactoring the update modal to work for create would actually be fine.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Lets users create entities in frontend!
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes