Skip to content

test-images: check contents of version.txt#1660

Merged
alxndrsn merged 1 commit intogetodk:nextfrom
alxndrsn:test-version-text
Feb 22, 2026
Merged

test-images: check contents of version.txt#1660
alxndrsn merged 1 commit intogetodk:nextfrom
alxndrsn:test-version-text

Conversation

@alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Feb 20, 2026

Document expected contents of version.txt and allow future changes to be detected by a failing test.

Ref #738 (comment)

What has been done to verify that this works as intended?

  • ran the code locally and see it works
  • ran in CI and inspected the output

Why is this the best possible solution? Were any other approaches considered?

It's questionable if the current behaviour is correct. At least with a test in place this is visible, and future changes should be easier to verify.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No effect.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Document expected contents of `version.txt` and allow future changes to be detected by a failing test.
@alxndrsn alxndrsn marked this pull request as ready for review February 20, 2026 07:53
@alxndrsn alxndrsn merged commit 04e5a83 into getodk:next Feb 22, 2026
5 checks passed
@alxndrsn alxndrsn deleted the test-version-text branch February 22, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants