Skip to content

csp: include report samples where supported #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alxndrsn wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

csp: include report samples where supported #1691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 82 additions & 9 deletions test/nginx/test-nginx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ chai.use(deepEqualInAnyOrder);
const { assert } = chai;

const none = `'none'`;
const reportSample = `'report-sample'`;
const self = `'self'`;
const unsafeInline = `'unsafe-inline'`;
const wasmUnsafeEval = `'wasm-unsafe-eval'`;
Expand All @@ -34,10 +35,16 @@ const allowGoogleTranslate = ({ 'connect-src':connectSrc, 'img-src':imgSrc, ...o

const contentSecurityPolicies = {
'backend-unmodified': {
'default-src': 'NOTE:FROM-BACKEND',
'default-src': [
reportSample,
'NOTE:FROM-BACKEND',
],
},
'central-frontend': allowGoogleTranslate({
'default-src': none,
'default-src': [
reportSample,
none,
],
'connect-src': [
self,
],
Expand All @@ -53,22 +60,40 @@ const contentSecurityPolicies = {
'manifest-src': none,
'media-src': none,
'object-src': none,
'script-src': self,
'style-src': self,
'script-src': [
reportSample,
self,
],
'style-src': [
reportSample,
self,
],
'style-src-attr': unsafeInline,
'worker-src': 'blob:',
'worker-src': [
reportSample,
'blob:',
],
'report-uri': '/csp-report',
}),
'disallow-all': {
'default-src': none,
'default-src': [
reportSample,
none,
],
'report-uri': '/csp-report',
},
'disallow-all-except-standard-plugins': allowGoogleTranslate({
'default-src': none,
'default-src': [
reportSample,
none,
],
'report-uri': '/csp-report',
}),
enketo: allowGoogleTranslate({
'default-src': none,
'default-src': [
reportSample,
none,
],
'connect-src': [
self,
'blob:',
Expand Down Expand Up @@ -101,6 +126,7 @@ const contentSecurityPolicies = {
],
'object-src': none,
'script-src': [
reportSample,
unsafeInline,
self,
'https://maps.googleapis.com/maps/api/js/',
Expand All @@ -116,7 +142,10 @@ const contentSecurityPolicies = {
'report-uri': '/csp-report',
}),
'web-forms': allowGoogleTranslate({
'default-src': none,
'default-src': [
reportSample,
none,
],
'connect-src': [
self,
'https:',
Expand All @@ -135,6 +164,7 @@ const contentSecurityPolicies = {
'media-src': none,
'object-src': none,
'script-src': [
reportSample,
self,
wasmUnsafeEval,
],
Expand All @@ -143,12 +173,55 @@ const contentSecurityPolicies = {
unsafeInline,
],
'worker-src': [
reportSample,
'blob:'
],
'report-uri': '/csp-report',
}),
};

describe('contentSecurityPolicies', () => {
const supportsReportSample = [
'default-src',
'require-trusted-types-for',
'script-src',
'script-src-attr',
'script-src-elem',
'style-src',
'style-src-attr',
'style-src-elem',
'worker-src',
];

for(const [name, policy] of Object.entries(contentSecurityPolicies)) {
describe(`policy: ${name}`, () => {
for(const [key, directive] of Object.entries(policy)) {
describe(`directive: ${key}`, () => {
if(supportsReportSample.includes(key)) {
if(key.startsWith('style-src') && directive.includes(`'unsafe-inline'`)) {
// For style-* directives, report-sample will only provide a sample of inline violations.
it(`should not include 'report-sample' in directive '${key}' when 'unsafe-inline' is allowed`, () => {
// expect
assert.notInclude(directive, "'report-sample'");
});
} else {
it(`should include 'report-sample' in directive '${key}'`, () => {
// expect
assert.include(directive, "'report-sample'");
});
}
} else {
it(`should not include 'report-sample' in directive '${key}'`, () => {
// expect
assert.notInclude(directive, "'report-sample'");
});
}
});
}
});
}
});

describe('nginx config', () => {
beforeEach(() => Promise.all([
resetEnketoMock(),
Expand Down
Loading