Remove pytz dependency, require Python 3.9+, extend tests#43
Merged
justinmayer merged 7 commits intogetpelican:mainfrom Jul 14, 2025
Merged
Remove pytz dependency, require Python 3.9+, extend tests#43justinmayer merged 7 commits intogetpelican:mainfrom
pytz dependency, require Python 3.9+, extend tests#43justinmayer merged 7 commits intogetpelican:mainfrom
Conversation
Member
Contributor
Author
|
After this I also downloaded pelican and made a test run with my modified branch. No failures. However I saw a few skipped tests due to missing locales. |
venthur
reviewed
Mar 11, 2025
venthur
reviewed
Mar 11, 2025
venthur
reviewed
Mar 11, 2025
venthur
reviewed
Mar 11, 2025
hugovk
reviewed
Mar 11, 2025
Contributor
hugovk
left a comment
There was a problem hiding this comment.
Also:
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 5b811c0..d2d7027 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -1,7 +1,7 @@
---
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
- rev: v4.6.0
+ rev: v5.0.0
hooks:
- id: check-added-large-files
- id: check-ast
@@ -15,7 +15,7 @@ repos:
- id: trailing-whitespace
- repo: https://github.com/asottile/pyupgrade
- rev: v3.15.2
+ rev: v3.19.1
hooks:
- id: pyupgrade
- args: [--py38-plus]
+ args: [--py39-plus]
Contributor
Author
|
Everything addressed. Thanks for the review |
Collaborator
|
Thanks for your contribution and addressing all requests @do3cc! @justinmayer the PR looks good to go. |
hugovk
approved these changes
Mar 13, 2025
venthur
approved these changes
Mar 13, 2025
Member
Also, force tests to use it, to check if it works with all OS
Contributor
Author
|
No worries, I just did so. |
justinmayer
reviewed
Jul 14, 2025
pytz dependency, require Python 3.9+, extend tests
Contributor
Author
|
I have also changed the github workflow again. I got some feedback from earlier reviews not do the optimizations that I just reverted and I somehow managed to loose them during the refactoring. |
justinmayer
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR to implement #42
I've reviewed timezone/utils.py and noticed a lot of code isn´t used at all.
Then I added tests for windows and macos to make sure, nothing breaks.
Since nothing broke, I got worried and extended the tests to use timezones as provided by Python 3.9.
Then my windows tests failed and I added the necessary dependency for windows.
Now that I am writing this, I am wondering whether we should depend on tzinfo, for windows, as we don´t use the available timezones anywhere. However, I like that there are tests for that.