Add docstring for each procedure and method for pelican/__init__.py#3359
Open
egberts wants to merge 2 commits intogetpelican:mainfrom
Open
Add docstring for each procedure and method for pelican/__init__.py#3359egberts wants to merge 2 commits intogetpelican:mainfrom
egberts wants to merge 2 commits intogetpelican:mainfrom
Conversation
added 2 commits
July 5, 2024 09:27
Setting terminal screen to 80x24, test the docstring using:
python -c "import pelican;help(pelican)"
Tiny adjustments to ensure that all comment lines are under 70-columns.
Contributor
|
I am only one voice, and I don't have much influence over whether this gets merged, but .. I'd be concerned that the long comments would get out of date. Anything that is not unit tested or with eyes on it eventually breaks. For example, the very long comments (e.g., at the top, in Also, I'd be more interested in type hints, for example. Instead of ":returns None", how about "-> None" on the function signature. Those are also not currently checked, but at least I'd see if they were wrong in my IDE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Add missing docstrings to
pelican/__init__.py.Zero code change.
Just a rough cut to see if the Pelican community are up for that. ( I know some folks like comment-less code so treading lightly here).