Change order of SUFFIXES so index.html is served first#3388
Open
RichGibson wants to merge 1 commit intogetpelican:mainfrom
Open
Change order of SUFFIXES so index.html is served first#3388RichGibson wants to merge 1 commit intogetpelican:mainfrom
RichGibson wants to merge 1 commit intogetpelican:mainfrom
Conversation
… '.html' exists. A file named .html should not exist in output. But somehow I ended up with one, and it was difficult to debug. Changing the order of the SUFFIXES allows the index.html file to be served before checking for .html.
pauloxnet
approved these changes
Aug 7, 2024
Member
pauloxnet
left a comment
There was a problem hiding this comment.
There's some test to update to merge this fix?
Author
|
I am not sure what the test would look like, I'm sorry. |
Contributor
|
I don't understand why this pull request didn't run tests. When it runs test_server.py I believe it will fail due to these lines: It failed when I ran it locally. To prevent your issue, you might have to do something more complicated, such as "if foo is a directory, then look for index.html first"? I don't understand get_path_that_exists deeply. |
Contributor
|
FYI the test failure on my box: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A file named .html should not exist in the output directory.
Somehow I ended up with one, and it was difficult to debug. Changing the order of the SUFFIXES allows the index.html file to be served before checking for .html.