[FIX] Match all occurrences of {static} / {attach}

[mart-e]

If a markup element contains more than one {static} or {attach} value, only the last one was replaced.

Simplify the regex to match every occurrence.
This regex no longer checks for < at the start which may imply false positive (to test if acceptable or not).

Detail of the issue: #3419

[pauloxnet]

Can you add a test?

[justinmayer]

@mart-e: There is a test failure, which needs to be addressed. If that test failure is due to the updated regex now actually correctly replacing the second {static} reference (and please make sure that is actually the case — I have not looked at length), then you can update the functional test output as described in the docs.

[mart-e]

@justinmayer no that test failure is the test I am adding, looks like my patch is actually not working/not enough. I have some troubles to invoke the test suit on my machine (probably some setup issues).
Is there a way to use a debugger like pudb?

[justinmayer]

Let's start with getting the tests running on your local workstation… What have you done so far, and what seems to be the problem with running the tests?

[justinmayer]

Looks like your test now passes. Bravo, Martin! Well done 👏

[mart-e]

Ok, I have figured out what was the issue, missing file declaration in my new test.

What have you done so far, and what seems to be the problem with running the tests?

I used invoke setup to be sure my env is up to date and then invoke test on the main branch. The test_pelican.py is failing. The output is very long (output), my terminal doesn’t have enough scroll back to reach the beginning but the interesting part seems to be that for every file, I get

E           diff --git a/home/mat/other/pelican/pelican/tests/output/basic/feeds/all.atom.xml.orig b/home/mat/other/pelican/pelican/tests/output/basic/feeds/all.atom.xml.orig
E           new file mode 100644
E           index 00000000..5552b0ea
E           --- /dev/null
E           +++ b/home/mat/other/pelican/pelican/tests/output/basic/feeds/all.atom.xml.orig

[justinmayer]

I do not believe there should be any […].orig files in the Pelican repository, so those are likely leftover detritus of some Git operation. I suggest using something like fd, particularly with its command execution option, to remove those files. Perhaps something like:

cd ~/projects/pelican
fd --hidden --glob '*.orig' --exec trash

(Above requires you have some kind of trash executable such as https://github.com/andreafrancia/trash-cli or https://github.com/sindresorhus/macos-trash that can safely remove files without potentially-risky permanent deletion.)

[mart-e]

Oh you are right, much better when purging those files, I can run the tests now. Thanks a lot for your help 👍

As a sidenote, I am no longer the initial example with two attributes containing {static} for lazyloading images on my blog (as it required javascript to work).
I still think this change is valid but in case you have a doubts, feel free to reject this PR as the usecase is probably rare.

Or maybe somebody better than me in regex can find a way to achieve the same while still checking the starting <?