Skip to content

cli: retain workspace volume when volumes option is set #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ech0-de wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cli: retain workspace volume when volumes option is set #970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/popper/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def _get_container_kwargs(self, step, img, name):
"image": img,
"command": list(step.args),
"name": name,
"volumes": [f"{self._config.workspace_dir}:/workspace:Z",],
"volumes": [],
"working_dir": step.dir if step.dir else "/workspace",
"environment": self._prepare_environment(step),
"entrypoint": step.runs if step.runs else None,
Expand All @@ -315,6 +315,14 @@ def _get_container_kwargs(self, step, img, name):

self._update_with_engine_config(args)
args.update(step.options)

if "volumes" not in args:
args["volumes"] = []
else:
args["volumes"] = list(args["volumes"])

args["volumes"].append(f"{self._config.workspace_dir}:/workspace:Z")

log.debug(f"container args: {pu.prettystr(args)}\n")

return args
Expand Down