Advanced query search syntax for multi byte search #7546
+40
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshiokatsuneo
force-pushed
the
feat/advanced_query_search_syntax_for_multi_byte_search
branch
from
5c261f6 to
b82c389
Compare
|
Very nice. Do we also need to make a corresponding change to documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Before the PR, when multi byte search is enabled, query search only support "ILIKE" based filtering. There is no way to search multiple terms, queries.
This PR make it possible to search query by specifying column name, exact match, multiple term AND search.
For example:
- word
- name:word
- query:word
- "multiple words"
- name:"multiple words"
- word1 word2 word3
- word1 "multiple word" query:"select foo"
How is this tested?