Remove software-properties-common from Ubuntu installation #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The software-properties-common package is not actually used in the setup script and can be safely removed from Ubuntu installation as well. Tested on Ubuntu 22.04 - setup script runs successfully without this package.
There was a problem hiding this comment.
Pull request overview
This PR removes the unnecessary software-properties-common package from the Ubuntu installation function, following the same change made for Debian in PR #93. The package is not actually used anywhere in the setup script, and this change improves consistency between Debian and Ubuntu installations.
Key Changes:
- Removed
software-properties-commonfrom the Ubuntu Docker installation package list - Ensures consistency with the Debian installation function (which had the same package removed in PR #93)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
snickerjp
force-pushed
the
ubuntu-remove-software-properties
branch
from
712f0e1 to
3dbf603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
Following up on PR #93 which removed
software-properties-commonfrom Debian installation, this PR removes the same unnecessary package from Ubuntu installation.Changes
software-properties-commonfrom Ubuntu installation functionTesting
software-properties-commonRelated
This ensures both Debian and Ubuntu installations are consistent and don't include unnecessary packages.