Improved AOT Compatibility #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied fix from #4 in our local fork of the module.
In the end, someone will need to do the work to enable the AOT/trim/single file safety analyzers and [address all the warnings](https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/), but this is enough to have a golden path that makes `sample/StackTrace` project produce the same results under native AOT as under JIT. Necessary fixes: * `GetMethodBody` under AOT throws. This will not return anything useful under Mono with ILStrip either. The code simply needs to deal with it. * Runtime reflection stack doesn't guarantee referential equality of `MemberInfo`s (except for `TypeInfo`). This is also true on JIT-based runtimes, but there's even less caching on native AOT. Use operator `==`. * The reflection to read `TupleElementNamesAttribute` is trim-unfriendly and cannot be analyzed. Replace with no-reflection. * Some fallout from the previous point because the nullable annotations on the thing returned by reflection were wrong.
bruno-garcia
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to get main branch up to date with the internal fork we've been keeping that's used in sentry-dotnet. That fork includes a number of separate changes related to being able to build the module with AOT compilation enabled... Those changes do not make Ben.Demystifier AOT compatible. They simply wrap the unsafe sections of the Ben.Demystifier code in the appropriate attributes so that incompatibilities can be handled appropriately by calling code.
Note: various members in the fork that we've been maintaining were made internal. For the purposes of merging these changes back into main, these have been made public again. People using this repo independently of Sentry would expect/need these to be visible. Once this PR has been merged, we can update our internal fork from main and make these internal again. That's a process we'll need to continue indefinitely, which I'll document in the
sentry-dotnetrepo.