ci(coverage): use informational-patch input instead of sed hack#544
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧Coverage
Other
🤖 This preview updates automatically when you update the PR. |
Replace the sed-based codecov.yml patching with the new informational-patch action input from getsentry/codecov-action. On push events (main/release branches), informational-patch evaluates to 'true', making the patch check advisory. On PRs it evaluates to 'false', keeping it blocking.
BYK
force-pushed
the
ci/codecov-informational-input
branch
from
40305c0 to
0229435
Compare
Contributor
Codecov Results 📊✅ 126 passed | Total: 126 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1028 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 96.02% 96.02% —%
==========================================
Files 185 185 —
Lines 25805 25805 —
Branches 0 0 —
==========================================
+ Hits 24777 24777 —
- Misses 1028 1028 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #541. Replaces the
sed-basedcodecov.ymlpatching with the newinformational-patchaction input from getsentry/codecov-action (merged in getsentry/codecov-action#54).Changes
ci.yml: Remove thesedstep, addinformational-patch: ${{ github.event_name == 'push' }}to the codecov actioncodecov.yml: Remove thepatch.default.informationalsection (no longer needed)Behavior (unchanged)
codecov/projectcodecov/patchmain/release/**push