Skip to content

feat: Add sdkName option and symlink creation for SDK packages in registry#769

Merged
BYK merged 1 commit intomasterfrom
sig/add-sdk-name
Mar 10, 2026
Merged

feat: Add sdkName option and symlink creation for SDK packages in registry#769
BYK merged 1 commit intomasterfrom
sig/add-sdk-name

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Mar 10, 2026

Introduced sdkName option in the registry configuration to specify the SDK identifier for Sentry events and updated documentation to reflect the new sdkName option and its usage in package creation.

@s1gr1d s1gr1d requested a review from BYK March 10, 2026 14:05
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-10 14:10 UTC

@s1gr1d s1gr1d changed the title docs: add sdkName option and symlink creation for SDK packages in registry feat: Add sdkName option and symlink creation for SDK packages in registry Mar 10, 2026
@BYK BYK enabled auto-merge (squash) March 10, 2026 14:08
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Missing sdks/ directory creation before symlink call
    • Added recursive creation of the symlink parent directory before symlinkSync and updated the symlink test to cover the missing-sdks case.

Create PR

Or push these changes by commenting:

@cursor push ffc49cdce7

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

@BYK BYK merged commit 46e6648 into master Mar 10, 2026
20 checks passed
@BYK BYK deleted the sig/add-sdk-name branch March 10, 2026 14:10
s1gr1d added a commit to getsentry/sentry-javascript that referenced this pull request Mar 10, 2026
Small addition to this PR:
#19731

Reference (adds `sdkName`): getsentry/craft#769


Closes #19737 (added automatically)
andreiborza pushed a commit to getsentry/sentry-javascript that referenced this pull request Mar 11, 2026
Small addition to this PR:
#19731

Reference (adds `sdkName`): getsentry/craft#769


Closes #19737 (added automatically)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants