fix: reorder columns in Leaderboard component for consistency#368
fix: reorder columns in Leaderboard component for consistency#368JoshuaMoelans wants to merge 2 commits intomainfrom
Conversation
To be consistent with the 'Received/Sent' toggle at the top https://github.com/getsentry/gib-potato/blob/b6005c8afea5599c9781313ed8be21cd5072ed22/frontend/src/components/Filter.vue#L39-L54
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| </th> | ||
| <th scope="col" class="hidden md:table-cell py-3.5 px-3 text-right text-sm font-semibold"> | ||
| Sent | ||
| </th> |
There was a problem hiding this comment.
Header and data cell CSS classes are mismatched
Low Severity
The column reorder used two different strategies: the <th> elements were physically moved (keeping their CSS), but the <td> elements only had their text content swapped (keeping their CSS in place). This means the positional styling classes (relative, pl-3 vs px-3, pr-4) are now mismatched between each header and its data cells. For example, the "Received" header has relative pl-3 while its data cell has px-3, and the "Sent" header has px-3 while its data cell has relative pl-3 pr-4.
Additional Locations (1)
2 participants
To be consistent with the 'Received/Sent' toggle at the top
Before
After
