-
-
Notifications
You must be signed in to change notification settings - Fork 8
Feat: Allow repo specific dangerfile. #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@vaind What do you think of this feature? |
Q: Should I target V3? |
Hey, haven't had a chance to look yet but makes sense in general. |
sorry for the extra tests I added (they got reverted), I wasn't sure why danger for changelogs wasn't triggering, turned out there are new filters that it skips the changelog check based on the title description that didn't happen on V2. |
Testesd the following cases here: Run with extra-dangerfile and extra-install-packages Run with extra-dangerfile and malicious shell script Run with no extra parameters Run with extra-dangerfile, extra-install-packages and a valid diff check for extra-dangerfile |
@vaind I added the following steps:
|
b45617b
to
aac9829
Compare
Based on V2.
The PR allows the danger CI to also include
dangerfiles
from the repo. This is good since only one github comment is allowed per repo, meaning that without this change, the danger used by the repo will overwrite the comment done by this repo.This change adds a new step, loading an external
dangerfile
if set.It passes the default parameters as exposing the following items:
fail
The changes were tested on the following PR:
getsentry/sentry-react-native#5235 (comment)
How external libraries should be implemented
Here is a example file using the changes: https://github.com/getsentry/sentry-react-native/blob/3dcd68b8db138e90aff72d51e46f89a6b0b70b0c/scripts/check-replay-stubs.js
If there is approval on merging these changes on this repo, I will update the readme file with guides on how to use an external dangerfile
#skip-changelog