Add latest tag to multi-platform manifest#564
Merged
NicoHinderling merged 4 commits intomainfrom Feb 9, 2026
Merged
Conversation
Member
hubertdeng123
left a comment
hubertdeng123
left a comment
There was a problem hiding this comment.
Can we just change https://github.com/getsentry/launchpad/blob/main/devservices/config.yml#L25 to use the nightly image? Latest is somewhat opinionated here since it's the tag we use to associate for self-hosted released images
.github/workflows/image.yml
Outdated
| @@ -42,7 +42,7 @@ jobs: | |||
| tag_suffix: -${{ matrix.platform }} | |||
| ghcr: true | |||
| tag_nightly: true | |||
Member
There was a problem hiding this comment.
I think tag_nightly and tag_latest here should both be false, since we're tagging only in the multiplatform build
hubertdeng123
approved these changes
Feb 9, 2026
.github/workflows/image.yml
Outdated
| docker buildx imagetools create \ | ||
| --tag ghcr.io/getsentry/launchpad:${{ github.sha }} \ | ||
| --tag ghcr.io/getsentry/launchpad:nightly \ | ||
| --tag ghcr.io/getsentry/launchpad:latest \ |
Member
There was a problem hiding this comment.
I don't think we'd need the latest to be tagged here anymore
NicoHinderling
force-pushed
the
fix-latest-tagging-for-launchpad
branch
from
9bed6ad to
b6852ef
Compare
CI resolved ruff>=0.14.9 to 0.15.0 which formats ternary expressions in lambdas differently than 0.14.9. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ghcr.io/getsentry/launchpad:latestonly had alinux/arm64manifest because each arch buildindependently pushed
latest, with arm64 winning the racenightlyworked correctly because it was included in the multi-platform manifest step, butlatestwasnot
devservices up --mode launchpadon amd64 machinesChanges - Set
tag_latest: falseon individual arch builds to stop the race condition--tag ghcr.io/getsentry/launchpad:latestto thecreate-manifeststep solatestgets a proper multi-platform manifest likenightly## Verification
docker manifest inspect ghcr.io/getsentry/launchpad:latestshould show bothlinux/amd64andlinux/arm64devservices up --mode launchpadshould work on both architectures