Skip to content

Conversation

@jan-auer
Copy link
Member

@jan-auer jan-auer commented Dec 9, 2025

Changes the object signature and makes keys optional. This allows us to add an
optimization that skips checking for tombstones when server-assigned keys are
used.

This PR introduces a new type ObjectContext. It stores the usecase and scopes
of the object's ID. The ObjectId type now wraps a context and has convenience
constructors and getters for all its parts. This type can be used by auth
instead of the ObjectId, since the key part is not needed. This will further
allow us to provide auth on batch endpoints and collection operations.

The StorageService interface now has an insert_object that replaces the
former put_object. This method takes an optional key and internally creates
a random ID if needed.

@jan-auer jan-auer requested a review from a team as a code owner December 9, 2025 11:47
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

@jan-auer jan-auer merged commit 84e9dc6 into main Dec 9, 2025
19 checks passed
@jan-auer jan-auer deleted the ref/service-optional-key branch December 9, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants