ref(service): Make object key optional on insert #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the object signature and makes keys optional. This allows us to add an
optimization that skips checking for tombstones when server-assigned keys are
used.
This PR introduces a new type
ObjectContext. It stores the usecase and scopesof the object's ID. The
ObjectIdtype now wraps a context and has convenienceconstructors and getters for all its parts. This type can be used by auth
instead of the
ObjectId, since the key part is not needed. This will furtherallow us to provide auth on batch endpoints and collection operations.
The
StorageServiceinterface now has aninsert_objectthat replaces theformer
put_object. This method takes an optional key and internally createsa random ID if needed.