ref(server): Create extractors for params#238
Merged
Conversation
0cb71d0 to
cad60a1
Compare
lcian
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a new module in
objectstore-serverthat contains all extractorswe need for our web API.
The extractor for the auth-aware service has been moved into this module. This
gives us a cleaner separation between the HTTP layer and the auth logic, which
would even allow us to move that wrapper into a different crate. Additionally,
there are minor changes to it:
enforceflag. This is inferred fromOptionand documented on its new constructor.There are also two new extractors for
ObjectIdandObjectContext. Endpointsno longer have to use the Params types directly and also do not have to deal
with configuring the Sentry scope.
This change is a preparation for introducing killswitches.
Ref FS-227